Skip to content

release-macros(prepare): v1.8.0#3373

Merged
glihm merged 2 commits intomainfrom
prepare-release-macros
Oct 31, 2025
Merged

release-macros(prepare): v1.8.0#3373
glihm merged 2 commits intomainfrom
prepare-release-macros

Conversation

@tarrencev
Copy link
Contributor

@tarrencev tarrencev commented Oct 31, 2025 •
edited by coderabbitai bot
Loading

Automated changes by create-pull-request GitHub action

Summary by CodeRabbit

  • Chores
    • Updated package version metadata to 1.8.0 for macros.
    • Bumped workspace dependency dojo-types to 1.8.0.
    • Switched the types package from workspace-managed version to an explicit version (1.8.0) with accompanying notes for publishing.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 31, 2025 •
edited
Loading

Ohayo, sensei! 👋

Walkthrough

Workspace and package manifest version fields updated: macros package bumped 1.7.1 → 1.8.0, workspace dependency dojo-types bumped 1.7.2 → 1.8.0, and dojo/types package switched from workspace-managed version to explicit version = "1.8.0". No code logic changes.

Changes

Cohort / File(s) Summary
Macros package manifests
crates/dojo/macros/Cargo.toml, crates/dojo/macros/Scarb.toml		 package.version bumped from "1.7.1" to "1.8.0". No other metadata or dependency changes.
Workspace dependency bump
Cargo.toml		 Workspace dependency workspace.dependencies.dojo-types bumped from "1.7.2" to "1.8.0".
Types package explicit versioning
crates/dojo/types/Cargo.toml		 Removed version.workspace = true and added version = "1.8.0" with comments explaining explicit versioning for publishing. No other changes.

Sequence Diagram(s)

(Skipped — changes are metadata-only and do not affect runtime control flow.)

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Pay attention to crates/dojo/types/Cargo.toml where versioning was changed from workspace-managed to explicit (publishing implications).
  • Verify workspace dependency bump in top-level Cargo.toml aligns with the explicit package version.

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title "release-macros(prepare): v1.8.0" is directly related to the main changes in this pull request, which consist entirely of version bumps across multiple configuration files to prepare for a 1.8.0 release of the dojo macros package. The title uses a clear, conventional commit format that specifically identifies the scope (macros), the action (release preparation), and the target version, making it immediately understandable to anyone reviewing the commit history. The title accurately reflects the automated release preparation workflow and is not misleading or vague.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch prepare-release-macros
📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e259c9b and 74bb6e5.

⛔ Files ignored due to path filters (3)
  • Cargo.lock is excluded by !**/*.lock
  • crates/dojo/core/Scarb.lock is excluded by !**/*.lock
  • crates/dojo/macros/Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (2)
  • Cargo.toml (1 hunks)
  • crates/dojo/types/Cargo.toml (1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2024-11-05T04:30:12.852Z 
Learnt from: glihm
Repo: dojoengine/dojo PR: 2633
File: crates/dojo/world/src/contracts/abigen/world.rs:3809-0
Timestamp: 2024-11-05T04:30:12.852Z
Learning: Code in `crates/dojo/world/src/contracts/abigen/` is auto-generated and should be excluded from code reviews.

Applied to files:

  • Cargo.toml
🔇 Additional comments (3)
crates/dojo/types/Cargo.toml (1)

4-7: Ohayo sensei! 🎯 Version decoupling strategy is clear and intentional.

The transition from workspace-managed to explicit versioning is well-motivated by the comments explaining the need to publish dojo macros independently. This decoupling allows dojo-types to be released on its own schedule without blocking or being blocked by the main workspace.

Cargo.toml (2)

67-67: Consistent version alignment across workspace and crates.

The explicit version = "1.8.0" on the dojo-types dependency matches the version now declared in crates/dojo/types/Cargo.toml, ensuring no version mismatch. This maintains clarity given the intentional decoupling from workspace-managed versions.

43-43: Ohayo, sensei!

Asymmetry is intentional and correctly handled.

The verification confirms the version strategy is working as designed:

  • Workspace declares: dojo-types 1.8.0 (root Cargo.toml:67)
  • Macros pins explicitly: dojo-types 1.7.0 (crates/dojo/macros/Cargo.toml:23)
  • Other workspace members: use dojo-types.workspace = true to inherit 1.8.0

The macros crate decouples itself from workspace version bumps via explicit versioning, which aligns with the documented strategy that macros is excluded and released separately. No version conflicts detected among dependent crates.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@glihm glihm merged commit b3c2e82 into main Oct 31, 2025
4 checks passed
@glihm glihm deleted the prepare-release-macros branch October 31, 2025 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tarrencev @glihm